Include cluster name in WAGED async rebalance thread names#189
Open
LZD-PratyushBhatt wants to merge 2 commits into
Open
Include cluster name in WAGED async rebalance thread names#189LZD-PratyushBhatt wants to merge 2 commits into
LZD-PratyushBhatt wants to merge 2 commits into
Conversation
added 2 commits
May 28, 2026 00:36
The async baseline and best-possible calculation tasks run on single-thread executors with default JVM thread names (pool-N-thread-1), so WAGED rebalance failure logs lose cluster context when a single controller JVM hosts multiple WAGED-managed clusters. This makes correlating errors across clusters in shared log stores difficult. Rename the executor thread to WagedGlobalRebalance-<cluster> / WagedPartialRebalance-<cluster> for the duration of each task and restore the original name in a finally block (the executor's single thread is reused across submissions, so restoration prevents stale names from leaking into the next task). Also include the cluster name explicitly in the LOG.error messages for easier grep.
TestWagedRebalanceThreadNaming exercises GlobalRebalanceRunner and PartialRebalanceRunner through the synchronous WagedRebalancer test constructor. Two cases: - testThreadNameContainsClusterNameAndIsRestored: happy path. The injected RebalanceAlgorithm records Thread.currentThread() and its name on each calculate() invocation. We assert at least one global and one partial call were observed, every observed name matches WagedGlobalRebalance-<cluster> or WagedPartialRebalance-<cluster>, and the captured Thread refs have no WAGED prefix after the rebalance returns (proving the finally block restored). - testThreadNameRestoredEvenWhenAlgorithmThrows: failure path. A throwing algorithm captures the thread name during calculate() and then raises HelixRebalanceException. We assert names captured during the failing call still contain the cluster name, and the executor thread name is still restored after the exception propagates. This is the scenario where missing restoration would cause the most damage (next baseline calc logging under the wrong cluster).
6728c9c to
9d99098
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async baseline and best-possible calculation tasks run on single-thread executors with default JVM thread names (pool-N-thread-1), so WAGED rebalance failure logs lose cluster context when a single controller JVM hosts multiple WAGED-managed clusters. This makes correlating errors across clusters in shared log stores difficult.
Rename the executor thread to WagedGlobalRebalance- / WagedPartialRebalance- for the duration of each task and restore the original name in a finally block (the executor's single thread is reused across submissions, so restoration prevents stale names from leaking into the next task). Also include the cluster name explicitly in the LOG.error messages for easier grep.
Issues
(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
Description
(Write a concise description including what, why, how)
Tests
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)