Skip to content

Fix offline CUSTOMIZED evacuation check to use union instead of intersection#125

Open
LZD-PratyushBhatt wants to merge 1 commit into
devfrom
lzd/changeCustomizedResrouceEvacuationSemantic
Open

Fix offline CUSTOMIZED evacuation check to use union instead of intersection#125
LZD-PratyushBhatt wants to merge 1 commit into
devfrom
lzd/changeCustomizedResrouceEvacuationSemantic

Conversation

@LZD-PratyushBhatt
Copy link
Copy Markdown
Collaborator

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fix offline CUSTOMIZED evacuation check to use union instead of intersection
(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)

Description

  • Here are some details about my PR, including screenshots of any UI changes:

(Write a concise description including what, why, how)
For offline instances, treat blocking partitions as the union of CurrentState partitions and IdealState assignments, instead of only their intersection. This prevents false evacuation completion when IdealState partition names rotate but the instance still has CurrentState entries.

Context: this is the behavior that pinot desires. They want union and not the intersection(current behavior). Because of this behavior one of their instance was prematurely deleted.

Tests

Modified existing tests.

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@LZD-PratyushBhatt LZD-PratyushBhatt force-pushed the lzd/changeCustomizedResrouceEvacuationSemantic branch from 2fdda45 to e08b12f Compare February 21, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant