Expose p95 and declare commit-to-ack latency histograms#1020
Merged
akshayrai merged 2 commits intoMay 22, 2026
Conversation
Declares 95thPercentile alongside the existing 50/99/999 percentiles for eventsLatencyMs, eventsLatencyMsSlaIneligible, and throughputViolatingEventsLatencyMs so the p95 latency point is exposed on these histograms.
Adds BrooklinHistogramInfo entries for eventsCommitToAckLatencyMs and eventsCommitToAckLatencyMsSlaIneligible with p50/p95/p99/p999, matching the existing eventsLatencyMs declarations. Without these the metrics framework did not advertise percentile attributes for the commit-to-ack histograms.
akshayrai
changed the title
mittalprince
approved these changes
May 22, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
95thPercentileto the existing histogram declarations foreventsLatencyMs,eventsLatencyMsSlaIneligible, andthroughputViolatingEventsLatencyMs(previously only p50/p99/p999 were declared).BrooklinHistogramInfoentries foreventsCommitToAckLatencyMsandeventsCommitToAckLatencyMsSlaIneligible(added in Add eventsCommitToAckLatencyMs SLA metric #1018) with p50/p95/p99/p999 — without these the metrics framework did notadvertise percentile attributes for the commit-to-ack histograms.
All changes are in
EventProducer.getMetricInfos(); no runtime behavior changes — the underlying DropwizardSnapshotalready computes these percentiles.Testing Done
BrooklinHistogramInfo(PERCENTILE_50/95/99/999).