Set DEFAULT_NEW_STREAM_GRACE_PERIOD_MS to 0#1016
Merged
Merged
Conversation
Disables the SLA grace period by default so SLA metrics are emitted immediately for all new streams without a warmup window.
mittalprince
force-pushed
the
pmittal/default-grace-period-zero
branch
from
8852862 to
267def6
Compare
kanishkjaiswal2015
previously approved these changes
May 20, 2026
…_MS=0 Tests that assert SLA suppression during grace period were relying on the 2h default. Now that the default is 0, pass an explicit 2h grace period via props so they continue to test the intended behaviour.
harshOSS
approved these changes
May 20, 2026
manishGoyalCode
approved these changes
May 20, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_NEW_STREAM_GRACE_PERIOD_MSto0inEventProducerimmediately for all new streams without a 2-hour warmup window
Testing Done