Skip to content

Allow focus changes from Update#1960

Open
xarvic wants to merge 2 commits into
linebender:masterfrom
xarvic:focus-update
Open

Allow focus changes from Update#1960
xarvic wants to merge 2 commits into
linebender:masterfrom
xarvic:focus-update

Conversation

@xarvic
Copy link
Copy Markdown
Collaborator

@xarvic xarvic commented Sep 11, 2021

This PR adds the methods needed to change focus to UpdateCtx.

Christoph and others added 2 commits September 11, 2021 10:53
@jneem
Copy link
Copy Markdown
Member

jneem commented Oct 6, 2021

What's the status of this? I don't see anything wrong with it, but was it discussed somewhere?

@cmyr
Copy link
Copy Markdown
Member

cmyr commented Oct 7, 2021

I have reservations about this. It's possible that it's okay, but when events are triggered during update the interactions are complex.

I think for the time being I would prefer to handle this by dispatching a command; it isn't elegant but it is easier to understand the control flow.

@xStrom
Copy link
Copy Markdown
Member

xStrom commented May 25, 2022

was it discussed somewhere?

I think the genesis is in this zulip thread.

@xStrom
Copy link
Copy Markdown
Member

xStrom commented Jan 12, 2023

What's the status of this PR? @xarvic do you think we should still move forward with this?

If we should move forward, then please rebase on master and I will try to figure out if this change makes sense.
If you no longer think this is relevant then we can just close this PR.

@xStrom xStrom added the S-waiting-on-author waits for changes from the submitter label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author waits for changes from the submitter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants