Bump MSRV to 1.86#218
Merged
Merged
Conversation
This was released in April 2025, which is now more than a year ago. The reason I want this now is linebender#217, but it does also have user-facing improvements to constness.
(Presumably as-of linebender#166?)
DJMcNab
commented
May 6, 2026
| fn hypot(self, other: Self) -> Self => hypotf; | ||
| // Note: powi is missing because its libm implementation is not efficient | ||
| fn powf(self, n: Self) -> Self => powf; | ||
| fn round(self) -> Self => roundf; |
Member
Author
There was a problem hiding this comment.
This change needs sanity-checking; the current code never uses the round() function, except in a test.
Collaborator
|
This will require that Peniko bump MSRV from 1.85 to 1.86, but looking at what depends publicly on that, it doesn't seem like that's an issue. I don't see any big users of |
waywardmonkeys
approved these changes
May 6, 2026
xStrom
approved these changes
May 6, 2026
tomcur
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was released in April 2025, which is now more than a year ago. The reason I want this now is #217, but it
does also have user-facing improvements to constness.
I used Claude (Opus 4.6) to create the changelog entry.