UI Fixes for Frequenz and Bandwidth#53
Conversation
- Modified MainScreen to adjust the width (90.dp -> 100.dp) and font size (18.sp -> 15.sp) of the OutlinedTextField to fix text clipping. - Added bandwidthHz parameter to SpectrumDisplay to show the correct receiver bandwidth rather than a hardcoded 3 MHz string. - Adjusted minF and maxF label calculations dynamically based on the passed bandwidthHz. - In MainScreen, passed the basebandFilterBwHz parameter from rxConfig down to the SpectrumDisplay. Co-authored-by: limbo111111 <228673403+limbo111111@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Resolves Task A regarding the Frequenz-Textfeld clipping due to large font size and small width bounds. Resolves Task B regarding the hardcoded "BW 3 MHz" spectrum label which now accurately reflects rxConfig.basebandFilterBwHz, and updates max/min frequency limits appropriately.
PR created automatically by Jules for task 7367678508841362868 started by @limbo111111