Fix false missing key error for unencrypted Kia protocols (V1, etc.)#49
Conversation
Kia protocols V0, V1, V2, and V7 are unencrypted and do not use a manufacturer key. The `Java_com_rfcut_protocols_KatProtocols_getKeeloqKeyStatus` function previously categorized all "Kia" protocols as part of the KeeLoq family, which caused false "missing key" errors for these unencrypted protocols. This change adds an early return of `0` for these specific unencrypted Kia protocols, which signals to the application that no key is needed and allows the control pad and replay functionalities to work directly. Co-authored-by: limbo111111 <228673403+limbo111111@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
The
Java_com_rfcut_protocols_KatProtocols_getKeeloqKeyStatusJNI function was incorrectly flagging all protocols starting with "Kia" as encrypted, requiring a keystore key. This caused the UI to show a "Kein Manufacturer-Key bekannt" error for unencrypted protocols like Kia V1.This PR adds a targeted check to exclude the specific unencrypted Kia protocols (V0, V1, V2, and V7) from the KeeLoq check, returning
0(no key required) so they function correctly.PR created automatically by Jules for task 4738419145484720728 started by @limbo111111