Skip to content

Fix Kia protocol fallback, add fsk deviation, and refactor replay#48

Merged
limbo111111 merged 1 commit into
mainfrom
fix-kia-fsk-replay-10297650902002630749
Jun 16, 2026
Merged

Fix Kia protocol fallback, add fsk deviation, and refactor replay#48
limbo111111 merged 1 commit into
mainfrom
fix-kia-fsk-replay-10297650902002630749

Conversation

@limbo111111

Copy link
Copy Markdown
Owner
  • Fixed a critical issue in ControlPadController where KIA protocols were falling back incorrectly by failing to query KeeLoq key status.
  • Cleaned up debug code dump_keystore_keys_for_pandora_compare in Rust keystore.
  • Added a missing fskDeviationHz domain property to RfSignal and the database via a proper Room Migration, ensuring safe parsing and exporting in .sub files (with fallback to 25kHz).
  • Removed duplicated code in ReplayController by extracting performRawReplay.

PR created automatically by Jules for task 10297650902002630749 started by @limbo111111

- Updated ControlPadController to query key status for KIA protocols.
- Removed duplicated debug function in keystore/mod.rs.
- Added `fskDeviationHz` to Domain/Entity/Database (Room migration 3->4) and SubGhzFileHelper.
- Refactored `ReplayController` to use a single `performRawReplay` method, avoiding duplicated logic.

Co-authored-by: limbo111111 <228673403+limbo111111@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@limbo111111 limbo111111 merged commit 9fffe42 into main Jun 16, 2026
1 check passed
@limbo111111 limbo111111 deleted the fix-kia-fsk-replay-10297650902002630749 branch June 16, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant