Fix RX Race Condition, RSSI, Gain Validation, and Export Modulation#47
Conversation
… export modulation This commit addresses four independent bugs: 1. **Fix 1 (`MainViewModel.kt`)**: Fixes a race condition between the main thread (`startRx()`) and `Dispatchers.IO` (`processRxPacket()`) on `rxBuffer` by adding a dedicated `rxBufferLock` and synchronizing buffer access and manipulation. 2. **Fix 2 (`WaterfallProcessor.kt`)**: Fixes the RSSI measurement in `estimateRssi()` to find the peak magnitude across the entire capture buffer instead of just averaging the first 1000 samples. It also optimizes the calculation by delaying `Math.sqrt()` to the final peak squared magnitude value. 3. **Fix 3 (`SettingsScreen.kt`)**: Fixes unvalidated user input for RX LNA and RX VGA fields by enforcing acceptable ranges (`0..40` and `0..62` respectively) and dropping out-of-bounds inputs, consistent with existing behavior for TX fields. 4. **Fix 4 (`SubGhzFileHelper.kt`)**: Fixes `.sub` file exports by dynamically writing the correct FSK `Preset` line (`FuriHalSubGhzPreset2FSKDev238Async`) and passing the correct `useFm` boolean flag to `KatProtocols.demodulateIq()` when the signal's modulation type is `2FSK`. Added a `TODO` for future dynamic FSK deviation implementation. Co-authored-by: limbo111111 <228673403+limbo111111@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
limbo111111
deleted the
fix-rx-race-condition-rssi-gain-export-8407462129137964576
branch
1 participant
Fixes a race condition in the RX buffer in
MainViewModel, updates the RSSI calculation inWaterfallProcessorto look at the entire buffer, enforces range bounds for RX LNA and VGA inSettingsScreen, and fixes thePreset:line and JNI parameters for exporting FSK signals inSubGhzFileHelper.PR created automatically by Jules for task 8407462129137964576 started by @limbo111111