Set default baseband filter bandwidth to 1.75 MHz and fix FM Demodulator wiring#46
Conversation
…r modulation type - Update SettingsRepository.kt to set default rxBasebandBwFlow to 1_750_000. - Update Models.kt to set default basebandFilterBwHz to 1_750_000 for RxConfig and TxConfig. - Update SubGhzFileHelper.kt to correctly extract the Preset: line during .sub file parsing and determine the modulation type (2FSK or OOK_AM), returning it in the RfSignal. Co-authored-by: limbo111111 <228673403+limbo111111@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
limbo111111
deleted the
fix-baseband-bandwidth-and-fmdemodulator-10121342819325826050
branch
1 participant
rxBasebandBwFlowfromnullto1_750_000inSettingsRepository.kt.basebandFilterBwHzin bothRxConfigandTxConfigto1_750_000inModels.kt.Preset:line to check for "2FSK" inSubGhzFileHelper.kt, applying the propermodulationType("2FSK" or "OOK_AM") to the resultingRfSignal.PR created automatically by Jules for task 10121342819325826050 started by @limbo111111