Wire FM/2FSK Demodulation and TX into the RFCut Pipeline#44
Conversation
- Add `ModulationType` to Rust `ProtocolDecoder` trait. - Update `FmDemodulator` struct. - Wire `FmDemodulator` into `process_iq_inner` and `demodulateIq` via `use_fm` JNI boolean. - Add `FskReplaySession` logic and JNI methods (`createFskReplaySession`, `getNextFskIqChunk`, `destroyFskReplaySession`). - Adjust `EncodedReplaySession` handling to automatically toggle frequency vs. amplitude based on protocol `modulation()`. - Update Kotlin `KatProtocols` JNI declarations. - Add `modulationType` string to `RfSignal` and `RfSignalEntity` models. - Increment Room DB schema version to 3 with `MIGRATION_2_3` and generated `3.json` file. - Update `ReplayController.kt` to route raw timing replays through `createFskReplaySession` if `modulationType == "2FSK"`. - Explicitly pass `useFm = false` in `MainViewModel` RX stream for compatibility. Co-authored-by: limbo111111 <228673403+limbo111111@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Wired the existing, dormant
FmDemodulatorinto the active decode pipeline for both static IQ processing and streaming RX processing.Configured 2FSK raw encoding in JNI allowing
+deviation/-deviationtone toggling without mutating underlying protocols.Updated Kotlin domain models and room schemas to track standard modulations.
Intercepted all active RF generation controllers to accurately select replay session generation strategies based on captured modulation state.
PR created automatically by Jules for task 16384656065538306194 started by @limbo111111