Refactor client connection management and improve code formatting - #88
Open
NanaMein wants to merge 10 commits into
Open
Refactor client connection management and improve code formatting#88NanaMein wants to merge 10 commits into
NanaMein wants to merge 10 commits into
Conversation
…Groq api inference. Added app_state to hold those object.
…or a ready pgvector client connection
…nnection and resolve conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces clean architectural decoupling for connection management by migrating application startup/shutdown logic into a dedicated lifespan module and utilizing a centralized global application state (
app_state).Key Changes
main.pyVerbosity: Extracted FastAPI lifespan context manager logic into a new dedicated module (app/core/lifespan.py).app_state): Introduced a global state container to manage heavy client instances (Database/PGVectorStore, Groq LLM client, etc.).Requestobject.Benefits
main.py), startup lifecycle (lifespan.py), and service logic.