This repository was archived by the owner on May 31, 2021. It is now read-only.
修复slider滑屏失效和 设置初始值的bug - #355
Open
shoaly wants to merge 1 commit into
Open
Conversation
1. 返回上一次更新, 还是将 触屏事件限制到 containner内部, 否则这个页面无法滑动了
this.container.on($.touchEvents.move, $.proxy(this.touchMove, this))
// $(document.body).on($.touchEvents.move, $.proxy(this.touchMove, this)) // move even outside container
2. 当slider有初始化值, 比如30% 的时候, 我尝试设置weui-slider__track 和 weui-slider__handler 还有weui-slider-box__value, 然后发现bug发生在 : this.left = parseInt(this.container.find('.weui-slider__handler').css('left')), css里面的值是 百分比, left 没有乘以width 导致异常, 修改为:
var per = parseInt(this.container.find('.weui-slider__handler').css('left') )
this.left = this.width * per /100;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
返回上一次更新, 还是将 触屏事件限制到 containner内部, 否则这个页面无法滑动了$.touchEvents.move, $ .proxy(this.touchMove, this))$(document.body).on($ .touchEvents.move, $.proxy(this.touchMove, this)) // move even outside container
this.container.on(
//
当slider有初始化值, 比如30% 的时候, 我尝试设置weui-slider__track 和 weui-slider__handler 还有weui-slider-box__value, 然后发现bug发生在 : this.left = parseInt(this.container.find('.weui-slider__handler').css('left')), css里面的值是 百分比, left 没有乘以width 导致异常, 修改为:
var per = parseInt(this.container.find('.weui-slider__handler').css('left') )
this.left = this.width * per /100;