pull lp3 keyboard from jitpack instead of github packages - #144
Merged
Conversation
dupontgu
force-pushed
the
fix/keyboard-jitpack
branch
from
August 4, 2026 12:30
985fd7f to
6a7cbb6
Compare
brunoro
approved these changes
Aug 4, 2026
brunoro
left a comment
brunoro
left a comment
Contributor
There was a problem hiding this comment.
LGTM! tested locally and it built fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our keyboard builds were hosted via GitHub pacakges, which is great EXCEPT for the fact that you need valid/matching github username/token to pull even from public repos. Switched over to Jitpack, I don't believe there are any downsides other than a slightly slower first build.
closes #80