Skip to content

make: add docker image targets#132

Merged
djkazic merged 1 commit into
lightninglabs:masterfrom
ZZiigguurraatt:add_docker_make_targets
Jul 7, 2026
Merged

make: add docker image targets#132
djkazic merged 1 commit into
lightninglabs:masterfrom
ZZiigguurraatt:add_docker_make_targets

Conversation

@ZZiigguurraatt

Copy link
Copy Markdown
Contributor

No description provided.

@djkazic

djkazic commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@claude review this

@ZZiigguurraatt ZZiigguurraatt force-pushed the add_docker_make_targets branch from 1872b03 to b33fc33 Compare July 1, 2026 16:28
@ZZiigguurraatt

Copy link
Copy Markdown
Contributor Author

signed commit

@djkazic

djkazic commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Nit: default DOCKER_IMAGE := lndmon produces a docker push lndmon:<commit> that can never succeed (library namespace) and names the image differently than the canonical lightninglabs/lndmon that CI publishes.

@ZZiigguurraatt

Copy link
Copy Markdown
Contributor Author

that can never succeed (library namespace)

don't quite understand this statement

names the image differently than the canonical lightninglabs/lndmon that CI publishes.

this make target is supposed to be for dev use, not production CI.

@djkazic djkazic merged commit 4b630c9 into lightninglabs:master Jul 7, 2026
1 check passed
@ZZiigguurraatt ZZiigguurraatt deleted the add_docker_make_targets branch July 7, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants