Skip to content

collectors: initialize logging before constructing collectors #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
djkazic wants to merge 1 commit into from
Closed

collectors: initialize logging before constructing collectors #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions collectors/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,19 @@ import (
)

var (
// Logger for lndmon's main process.
Logger btclog.Logger
// Logger for lndmon's main process. It defaults to a disabled logger
// so that it is safe to use before initLogRotator has been called

@ZZiigguurraatt ZZiigguurraatt Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this cause messages to be missed if the logger never successfully is able to open the log file?

// (e.g. from collector goroutines launched at construction time).
Logger btclog.Logger = btclog.Disabled

// htlcLogger is a logger for lndmon's htlc collector.
htlcLogger btclog.Logger
htlcLogger btclog.Logger = btclog.Disabled

// paymentLogger is a logger for lndmon's payments monitor.
paymentLogger btclog.Logger
paymentLogger btclog.Logger = btclog.Disabled

// watchtowerLogger is a logger for lndmon's watchtower client.
watchtowerLogger btclog.Logger
watchtowerLogger btclog.Logger = btclog.Disabled

noOpShutdownFunc = func() {}
)
Expand Down
Loading