[10/15] Normalize identifiers before keying the auth rate limiter - #163
Open
UnknownJoe796 wants to merge 1 commit into
Open
[10/15] Normalize identifiers before keying the auth rate limiter#163UnknownJoe796 wants to merge 1 commit into
UnknownJoe796 wants to merge 1 commit into
Conversation
Contributor
Author
|
Looks fine to me. |
UnknownJoe796
force-pushed
the
v53/openapi-sdk-docs
branch
from
July 29, 2026 22:54
c31622d to
6286e37
Compare
UnknownJoe796
force-pushed
the
v53/auth-normalization
branch
from
July 29, 2026 22:54
1af4070 to
afcde3e
Compare
PasswordProofEndpoints, TimeBasedOTPProofEndpoints, and BackupCodeEndpoints built their constrainAttemptRate cache key from the raw input value while normalization happened only inside the rate-limited action. An attacker could therefore vary case/whitespace of an identifier to get a fresh limiter bucket per variant, dodging the limiter and its new exponential backoff. Resolve the principal handler and normalize the value before constructing the key, matching PinBasedProofEndpoints. Credential-matching behavior is unchanged. Tests assert case variants of one identifier share a single bucket. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 7a2d926) (cherry picked from commit afcde3e)
UnknownJoe796
force-pushed
the
v53/openapi-sdk-docs
branch
from
July 30, 2026 02:19
6286e37 to
8b29a23
Compare
UnknownJoe796
force-pushed
the
v53/auth-normalization
branch
from
July 30, 2026 02:19
afcde3e to
a123e57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identifiers are normalized before they key the auth rate limiter, so casing and
formatting variants of the same identifier can no longer be used to multiply the
allowed attempt budget. Applies to password, TOTP and backup-code proofs.