Fix single-EC2 Route53 AAAA record and daemon-reload ordering - #149
Open
UnknownJoe796 wants to merge 1 commit into
Open
Fix single-EC2 Route53 AAAA record and daemon-reload ordering#149UnknownJoe796 wants to merge 1 commit into
UnknownJoe796 wants to merge 1 commit into
Conversation
UnknownJoe796
commented
Jul 29, 2026
| "type" - "AAAA" | ||
| "ttl" - 300 | ||
| "records" - listOf(expression("aws_instance.ubuntu.ipv6_addresses")) | ||
| "records" - listOf(expression("aws_instance.ubuntu.ipv6_addresses[0]")) |
Contributor
Author
There was a problem hiding this comment.
Should this actually be
expression("aws_instance.ubuntu.ipv6_addresses")
instead?
Contributor
Author
There was a problem hiding this comment.
Further review, I believe this is OK; the suggestion would work but it will always be a single IP so this is safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two narrow single-EC2 deployment fixes, recovered from the stale
apple-ssobranch where they were bundled with unrelated Apple SSO work.
ipv6_addresses-- already a list -- inanother
listOf(...). Now indexes[0].systemctl daemon-reloadran aftersystemctl enable, so the reload couldnot see the unit it was meant to pick up. Moved before.
Terraform-only; no test coverage exists for the deploy builders, so this is
verified by compilation and review, not by tests.