Warning fixes - #184
Open
UnknownJoe796 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All compiler warnings across the entire project are now resolved. Summary:
Scope: library, library-camera, library-lottie, test-utilities, example-app, gradle-plugin, ai-driver-server — main and test sources, across JVM, JVM/SSR,
JS, and Android targets. 141 files touched.
Real bugs found and fixed along the way:
report bad routes.
distinguish "unchanged" from "changed to null" — fixed with an explicit comparison. (This is why 2 golden SSR snapshot tests needed regenerating — the fix
now correctly emits transform:none.)
no effect (the marker already lives on the Element/ElementWriter interfaces), unreachable else branches on exhaustive whens, tautological conditions in
gradle-plugin.
(renderListInExpensive/colOfExpensive/rowOfExpensive) already existed, just mis-named in the message.
"unresolved opt-in marker" warnings everywhere — rescoped to native targets only, across 5 modules.
Two things I flagged and you decided on:
it creates — for those call sites I kept the internal forEach/forEachAnimated with explicit @OptIn/@Suppress, documented inline. Worth a real fix later if
you want modifier-preserving list helpers.
Verification: every module's main + test sources compile warning-free on JVM/JVMSsr/JS/Android, and the full test suite (including the SSR golden-snapshot
tests) passes.