fix(pattern): repair garbled effect name for ID 240#534
Draft
bluetoothbot wants to merge 1 commit into
Draft
Conversation
The ORIGINAL_ADDRESSABLE_EFFECT_ID_NAME entry for effect 240 had its
clause order scrambled ("and return back7 colors each in blue run
circularly, multi points from start to end"), unlike its siblings 238-242.
Reorder to the standard form so the user-facing name and the reverse
name->ID lookup are correct.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Fix the garbled human-readable name for addressable effect ID 240.
Why: The
ORIGINAL_ADDRESSABLE_EFFECT_ID_NAMEentry for 240 had its clause order scrambled —"and return back7 colors each in blue run circularly, multi points from start to end"— diverging from siblings 238–242. The malformed string also becomes a malformed key in the reverseORIGINAL_ADDRESSABLE_EFFECT_NAME_IDmap, so name→ID lookup for this effect would fail.How: Reordered to the standard sibling form:
"7 colors each in blue run circularly, multi points from start to end and return back". String-only, no logic change.Testing:
pytest tests/— 140 passed.Quality Report
Changes: 1 file changed, 1 insertion(+), 1 deletion(-)
Code scan: clean
Tests: failed (FAILED)
Branch hygiene: clean
Generated by Kōan