Skip to content

fix(ics): correct mainnet performance eligibility#858

Merged
madlabman merged 2 commits into
developfrom
fix/ics-mainnet-performance-report-schema
Jul 21, 2026
Merged

fix(ics): correct mainnet performance eligibility#858
madlabman merged 2 commits into
developfrom
fix/ics-mainnet-performance-report-schema

Conversation

@skhomuti

Copy link
Copy Markdown
Contributor

Description

Fix mainnet CSM Experience eligibility evaluation:

  • parse legacy v1 and current v2/v3 performance report structures without silent field fallbacks;
  • discover the complete report history from DistributionLogUpdated events through the configured mainnet RPC and assessment cutoff;
  • permanently qualify operators after they accumulate at least 30 days of actual attestation activity;
  • evaluate performance exclusively against the latest report and its per-validator thresholds;
  • fail loudly on missing required report fields, empty reports, and unsupported v3 log revisions;
  • regenerate the mainnet eligibility artifact with 353 eligible operators.

The regenerated artifact contains 353 eligible operators, down from 411. It removes 58 operators that either fail the latest-report performance check or never accumulated 30 days of historical activity. No new operators are added relative to the existing artifact.

Checklist

  • Appropriate PR labels applied
  • Test coverage maintained (just coverage)
    • No need to add/update tests
    • Tests are added/updated
  • Documentation maintained
    • No need to update
    • Updated

@skhomuti
skhomuti requested a review from a team as a code owner July 20, 2026 09:21
@skhomuti
skhomuti requested review from dgusakov and madlabman July 20, 2026 09:21
dgusakov
dgusakov previously approved these changes Jul 20, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e309ad55fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ics_assessment/experience/performance.py
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@skhomuti
skhomuti force-pushed the fix/ics-mainnet-performance-report-schema branch from 9c527fd to ea6a69a Compare July 20, 2026 12:16

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3028e4f820

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ics_assessment/experience/performance.py
@madlabman
madlabman merged commit 4eca786 into develop Jul 21, 2026
6 checks passed
@madlabman
madlabman deleted the fix/ics-mainnet-performance-report-schema branch July 21, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants