[codex] Add ERC20 lock boost provider#822
Open
skhomuti wants to merge 3 commits into
Open
Conversation
dgusakov
reviewed
Jun 18, 2026
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
2 times, most recently
from
June 19, 2026 08:28
712c919 to
0407b20
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
June 22, 2026 14:05
0407b20 to
a8f0f49
Compare
vgorkavenko
reviewed
Jun 24, 2026
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
June 25, 2026 06:44
f8c45db to
bd8b09d
Compare
dgusakov
reviewed
Jun 26, 2026
dgusakov
reviewed
Jun 30, 2026
| /// @notice Initialize the provider. | ||
| /// @param admin Address to receive DEFAULT_ADMIN_ROLE. | ||
| /// @param lockPeriod Initial token lock period. | ||
| function initialize(address admin, uint256 lockPeriod) external; |
Contributor
There was a problem hiding this comment.
I think we have never included initialize in the interface
Contributor
There was a problem hiding this comment.
Well, we did it a few times. Make a todo to add others to the interfaces. To keep things consistent
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
June 30, 2026 09:32
8f72af6 to
d7c0102
Compare
skhomuti
force-pushed
the
feat/weight-boost-providers
branch
from
June 30, 2026 09:42
74ec710 to
6a29821
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
June 30, 2026 09:43
d7c0102 to
7ccca20
Compare
skhomuti
force-pushed
the
feat/weight-boost-providers
branch
from
June 30, 2026 10:14
6a29821 to
02b35d6
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
June 30, 2026 10:14
7ccca20 to
6135de9
Compare
skhomuti
force-pushed
the
feat/weight-boost-providers
branch
from
June 30, 2026 10:59
02b35d6 to
3d84c2d
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
June 30, 2026 10:59
6135de9 to
dd1b86c
Compare
skhomuti
force-pushed
the
feat/weight-boost-providers
branch
from
June 30, 2026 11:05
3d84c2d to
7c5bbc7
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
June 30, 2026 11:05
dd1b86c to
ed021d3
Compare
skhomuti
force-pushed
the
feat/weight-boost-providers
branch
from
July 1, 2026 14:25
7c5bbc7 to
ff17e9e
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
July 1, 2026 14:25
ed021d3 to
19dca86
Compare
skhomuti
force-pushed
the
feat/weight-boost-providers
branch
from
July 1, 2026 14:35
ff17e9e to
16bedaa
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
July 1, 2026 14:35
19dca86 to
5df38bc
Compare
skhomuti
force-pushed
the
feat/weight-boost-providers
branch
from
July 1, 2026 14:49
16bedaa to
ea37008
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
July 1, 2026 14:50
5df38bc to
935a227
Compare
skhomuti
force-pushed
the
feat/weight-boost-providers
branch
from
July 1, 2026 15:43
ea37008 to
07eb55e
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
July 1, 2026 15:43
935a227 to
71dec95
Compare
Closed
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
July 2, 2026 08:53
71dec95 to
b342310
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
July 24, 2026 07:06
b342310 to
0a0c6c2
Compare
skhomuti
marked this pull request as ready for review
July 24, 2026 07:06
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a0c6c2f14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // LDO lock boost provider | ||
| config.ldoLockBoostProviderConfig.token = 0xEf2573966D009CcEA0Fc74451dee2193564198dc; | ||
| config.ldoLockBoostProviderConfig.votingContract = 0x49B3512c44891bef83F8967d075121Bd1b07a01B; | ||
| config.ldoLockBoostProviderConfig.snapshotDelegation = address(1); // TODO: Fill in before deployment |
There was a problem hiding this comment.
In Hoodi deployments this placeholder is copied into the Lido lock vault implementation as the immutable Snapshot delegation registry address, and every vault created from that beacon will call it from assignSnapshotDelegate/unassignSnapshotDelegate. With address(1) deployed, Hoodi operators cannot actually delegate their locked LDO voting power for Snapshot without a vault implementation upgrade, so the deploy script should use the real Hoodi delegation registry or fail fast until it is known.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary