Add (mostly failing) test cases for ReferenceParser - #2
Conversation
Cleaning removed trailing dots, turning an author list like `Doe, J., Bar, F.` into `Doe, J., Bar, F`.
|
@lidianycs Here are some of the issues I noted (run the tests to see concrete examples):
|
|
@fzieris many thanks for the update! We're definitely needing test cases. I'll look into it to release a new version. |
|
Hi @fzieris, thanks again for the update! I'd appreciate it if you could keep working on it. Sorry for the delay in merging the PR, but I was only able to analyze it today. This week I'll be working on other updates in the tool, so I hope to be able to give a fast answer this time. 🙏🏾 |
I did already. I've been playing around with GROBID as an alternative reference parser that people could run a Docker container and that Cerca calls via its REST API. The quality for both authors and titles is much higher (i.e., all test cases pass). I'll create a PR for this soon. |
|
@fzieris I really appreciate it! I've looked at GROBID too, but unfortunately the need to run a Docker container would be a downer in this scenario because it'd difficult the use by non Tech savvy users. I'm considering creating a PDF parser and using an updated ML model to find the references but I'd prefer to keep it abstracted for the users. |
|
Hi @fzieris I was looking into it again today and unfortunately what I was trying didn't workout. I read GROBID docs again to see if there's a way of using it without hassling the users but didn't find a way. Let me know if you think of something. Thanks! |
|
@lidianycs Check out my draft PR: #11 The PR follows the rules "make the change easy, then make the easy change": Feel free to cherry-pick bits and pieces from that PR. |
Author and title extraction don't work super-well right now.
This PR adds a small number of failing test cases and provides a fix for one simple case
(needless removal of trailing dots in abbreviated author names).