Skip to content

Profiles#19067

Open
fpscan wants to merge 4 commits into
libretro:masterfrom
fpscan:feature-profiles
Open

Profiles#19067
fpscan wants to merge 4 commits into
libretro:masterfrom
fpscan:feature-profiles

Conversation

@fpscan
Copy link
Copy Markdown
Contributor

@fpscan fpscan commented May 26, 2026

image image image image

Guidelines

  1. Rebase before opening a pull request
  2. If you are sending several unrelated fixes or features, use a branch and a separate pull request for each
  3. If possible try squashing everything in a single commit. This is particularly beneficial in the case of feature merges since it allows easy bisecting when a problem arises
  4. RetroArch codebase follows C89 coding rules for portability across many old platforms check using C89_BUILD=1

Description

[Description of the pull request, detail any issues you are fixing or any features you are implementing]

Related Issues

[Any issues this pull request may be addressing]

Related Pull Requests

[Any other PRs from related repositories that might be needed for this pull request to work]

Reviewers

[If possible @mention all the people that should review your pull request]

@hizzlekizzle
Copy link
Copy Markdown
Collaborator

hizzlekizzle commented May 26, 2026

This is a very common request among handheld users. @sonninnos

EDIT: @fpscan looks like you have some C89 compliance errors:

profile_manager.c:310:4: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  310 |    int idx = g_profile_list.active_index;
      |    ^~~
profile_manager.c: In function ‘profile_manager_create’:
profile_manager.c:346:4: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  346 |    char sanitized[128];
      |    ^~~~
profile_manager.c: In function ‘profile_manager_save_current’:
profile_manager.c:424:4: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  424 |    char dst_path[PATH_MAX_LENGTH];
      |    ^~~~
profile_manager.c: In function ‘profile_manager_delete’:
profile_manager.c:453:4: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  453 |    int i;
      |    ^~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants