docs(gossipsub-v1.4): Add design document for large message propagation#720
Open
NomzzNJS wants to merge 4 commits into
Open
docs(gossipsub-v1.4): Add design document for large message propagation#720NomzzNJS wants to merge 4 commits into
NomzzNJS wants to merge 4 commits into
Conversation
- Add comprehensive design-document.md covering prototype analysis (nim-libp2p, py-libp2p), design rationale, protocol flow diagrams, wire format design, security model, and performance expectations - Link design document from gossipsub README - Fix author attribution to @NomzzNJS
|
I reviewed it out of curiosity. There are so many issues and errors in this. Some of them which i found are -
These are what I was able to find and i believe there are more architectural contradictions here. @seetadev, I would like your opinion here. Your input would be helpful. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a comprehensive design document for the Gossipsub v1.4 Large Message
Propagation specification, formalizing the design based on existing nim-libp2p
and py-libp2p prototype implementations.
What's Included
[NEW] pubsub/gossipsub/design-document.md
bandwidth amplification quantification
and py-libp2p implementations
version bump, 64KB fragments, advisory IMRECEIVING, etc.)
redundancy suppression, and reassembly state machine
overhead analysis (<0.1%)
reduction, 35% latency improvement)
[MODIFIED] pubsub/gossipsub/README.md