🚨 (patch) Fix compiler warnings and cleanup code#81
Merged
Merged
Conversation
kammce
commented
Jul 11, 2025
- WARNING this PR has a bug where the LR registers is equal to the PC register. Khalil, you wrote this here so you won't forget it before merging this. Remove after breakfast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- WARNING this PR has a bug where the LR registers is equal to the PC register. Khalil, you wrote this here so you won't forget it before merging this. Remove after breakfast.This shouldn't be an issue as the LR register is in function's frame as it must have been pushed there when entering the function.