🐛 (patch) Wrap _Unwind_Resume#78
Merged
Merged
Conversation
When using LTO, the compiler may emit a `_Unwind_Resume` call rather than a `__cxa_end_cleanup` at the end of a landing pad. Calling GCC's unwinder while the estell unwinder is running will be UB. This wraps that API to call our `__cxa_end_cleanup`. The pointer to the current exception object passed to _Unwind_Resume, is ignored.
kammce
force-pushed
the
override-unwind-resume
branch
from
15a1e45 to
c6e7d9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using LTO, the compiler may emit a
_Unwind_Resumecall rather than a__cxa_end_cleanupat the end of a landing pad. Calling GCC's unwinder while the estell unwinder is running will be UB. This wraps that API to call our__cxa_end_cleanup. The pointer to the current exception object passed to _Unwind_Resume, is ignored.