Include programs in meson build's installations#723
Open
stenczelt wants to merge 3 commits into
Open
Conversation
Add install: true to all executable() calls in src/Programs/meson.build so that meson install places gap_fit, quip, and all other programs into the prefix bin/ directory. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds --prefix, meson install, and a sanity check that gap_fit lands in the installed bin/ directory, catching any regression of issue #722. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
Thanks - yes, release comes from tag so leave this out for now. Note that gap_fit and quip executables were already distributed in PyPI releases, so please check this hasn't been broken too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
install: trueto programs, sogap_fitis installed by themesonbuild system as well in<prefix>/bin/*. The CI now runs install as well, and tests that the executable had been created there.Also bumped the version to
0.10.4, but I see this is not tied to the releases on github. Should I revert this @jameskermode?For #722.