Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/developers-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ the hexagonal port/adapter pattern:
`render(&self, view: &GraphView, sink: &mut dyn io::Write) -> Result<(), GraphRenderError>`.
Adapters consume `GraphView` only — they never touch `BuildGraph` directly.
- [`DotRenderer`](../src/graph_view/render_dot.rs) emits Graphviz DOT.
- [`HtmlRenderer`](../src/graph_view/render_html.rs) emits a self-contained
- [`HtmlRenderer`](../src/graph_view/render_html/mod.rs) emits a self-contained
HTML page (server-rendered SVG, accessible textual outline, and a
`<noscript>` fallback containing the DOT source verbatim).

Expand Down
7 changes: 4 additions & 3 deletions docs/netsuke-design.md
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,7 @@ accept optional `phony` and `always` booleans. They default to `false`, making
it explicit when an action should run regardless of file timestamps. Targets
listed in the `actions` section are deserialized using a custom helper so they
are always treated as `phony` tasks. This ensures preparation actions never
generate build artefacts. Convenience functions in `src/manifest.rs` load a
generate build artefacts. Convenience functions in `src/manifest/mod.rs` load a
manifest from a string or a file path, returning `anyhow::Result` for
straightforward error handling. Diagnostics now wrap source and manifest
identifiers in the `ManifestSource` and `ManifestName` newtypes, allowing
Expand Down Expand Up @@ -2433,9 +2433,10 @@ manifest parsing, stdlib template errors, and runner failures) use the same
Fluent localizer so the locale selection is consistent across user-facing
output. A build-time audit in `build.rs` validates that all referenced Fluent
message keys exist in the bundled catalogues, ensuring missing strings fail CI
before release. CLI execution and dispatch live in `src/runner.rs`, keeping
before release. CLI execution and dispatch live in `src/runner/mod.rs`, keeping
`main.rs` focused on parsing. Process management, Ninja invocation, argument
redaction, and the temporary file helpers reside in `src/runner/process.rs`,
redaction, and the temporary file helpers reside in
`src/runner/process/mod.rs`,
allowing the runner entry point to delegate low-level concerns. The working
directory flag mirrors Ninja's `-C` option but is resolved internally: Netsuke
runs Ninja with a configured working directory and resolves relative output
Expand Down
6 changes: 3 additions & 3 deletions docs/rust-testing-with-rstest-fixtures.md
Original file line number Diff line number Diff line change
Expand Up @@ -1126,9 +1126,9 @@ for maintainability and scalability.
(in the `tests/` directory), consider creating a common module within the
`tests/` directory (e.g., `tests/common/fixtures.rs`) and re-exporting
public fixtures.
- Alternatively, define shared fixtures in the library crate itself (e.g., in
`src/lib.rs` or `src/fixtures.rs` under `#[cfg(test)]`) and `use` them in
integration tests.
- Alternatively, define shared fixtures in the library crate itself (e.g.,
in `src/lib.rs` or a dedicated fixtures module under `#[cfg(test)]`) and
`use` them in integration tests.
- **Naming Conventions:** Use clear, descriptive names for fixtures that
indicate what they provide or set up. Test function names should clearly
state what behaviour they are verifying.
Expand Down
Loading