Stock logic fix#36
Merged
Merged
Conversation
Closed
There was a problem hiding this comment.
Pull request overview
This pull request aims to fix stock logic by moving stock and isActive properties from ProductDetail to ProductSummary interface to make them available across the application. The changes add conditional rendering to hide purchase buttons and reviews for products that are out of stock or inactive.
Changes:
- Moved
stockandisActivefields fromProductDetailtoProductSummaryinterface in both frontend TypeScript types and backend Java DTO - Added conditional rendering in
ProductPageandProductCardcomponents to show "Out of Stock" message based on product availability - Created new
CustomButtonGroupcomponent to consolidate button group logic fromProductCard - Added "outOfStock" translation string
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/types/ProductsType.ts | Moved stock and isActive properties from ProductDetail to ProductSummary interface |
| backend/src/main/java/com/matchmycoffee/dto/response/product/ProductSummaryResponse.java | Added stock and isActive fields to backend DTO to match frontend changes |
| frontend/src/pages/ProductPage.tsx | Added conditional rendering for purchase buttons and reviews section based on stock/active status |
| frontend/src/components/common/ProductCard.tsx | Refactored to use CustomButtonGroup and added stock availability check |
| frontend/src/components/product/CustomButtonGroup.tsx | New component extracting button group logic from ProductCard |
| frontend/public/locales/en/translation.json | Added "outOfStock" translation string |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.