Skip to content

feat/custom functions#61

Merged
kellywsq03 merged 3 commits into
mainfrom
feat/custom-functions
Mar 26, 2026
Merged

feat/custom functions#61
kellywsq03 merged 3 commits into
mainfrom
feat/custom-functions

Conversation

@KennyLewi

@KennyLewi KennyLewi commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

added custom function:
IF: (condition, true_result, false_result)

also implemented better simulation error messages by replacing IDs with labels
image

closes #59
closes #53

@codecov-commenter

codecov-commenter commented Mar 19, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 82 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.74%. Comparing base (3433210) to head (95b26ee).

Files with missing lines Patch % Lines
client/src/utils/displayEquationHelpers.ts 0.00% 38 Missing and 30 partials ⚠️
client/src/utils/equationValidationRegex.ts 0.00% 8 Missing ⚠️
client/src/actions/simulation.ts 0.00% 5 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   26.64%   25.74%   -0.90%     
==========================================
  Files          78       78              
  Lines        1888     1954      +66     
  Branches      323      349      +26     
==========================================
  Hits          503      503              
- Misses       1201     1242      +41     
- Partials      184      209      +25     
Flag Coverage Δ
client 14.09% <0.00%> (-0.59%) ⬇️
server 87.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread client/src/utils/displayEquationHelpers.ts
@kellywsq03

Copy link
Copy Markdown
Collaborator

if you rename any entity to IF, the simulation fails
this is some silly edge case but we can consider preventing function names in labels

@kellywsq03
kellywsq03 merged commit fb5393f into main Mar 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: better simulation error messages feat: funny functions (v1 easy)

3 participants