simulation logic for backend and chart plotting for frontend#25
Merged
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 27.61% 26.64% -0.98%
==========================================
Files 72 78 +6
Lines 1767 1888 +121
Branches 287 323 +36
==========================================
+ Hits 488 503 +15
- Misses 1118 1201 +83
- Partials 161 184 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leslieyip02
requested changes
Feb 2, 2026
KennyLewi
force-pushed
the
feat/simulation
branch
from
February 9, 2026 10:21
a487075 to
8543884
Compare
KennyLewi
force-pushed
the
feat/simulation
branch
from
February 18, 2026 04:17
17431a4 to
84bcc1a
Compare
…other room members
entity must be preceeded by a space. support parentheses in equation update equation error as draft equation is updated update equation error as draft equation is updated add mathjs parser check in equation validation add badges to cursor position. centralize validation refactor equationError to use a custom error message string only commit equation in the absence of errors highlight badges of unincluded labels remove redundant validation check fix bug where error message flashes when concurrent user edits label for parent node parse space-separated tokens add space between cursor adn badge
feat: equation bug fixes
Owner
|
@KennyLewi Merged with |
leslieyip02
requested changes
Mar 10, 2026
leslieyip02
left a comment
leslieyip02
left a comment
Owner
There was a problem hiding this comment.
Algorithms are probably correct but I think we need to improve the UX.
leslieyip02
reviewed
Mar 10, 2026
leslieyip02
approved these changes
Mar 18, 2026
leslieyip02
left a comment
leslieyip02
left a comment
Owner
There was a problem hiding this comment.
LGTM.
Note: I changed the API URL pattern to standardize with other API calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes:
topologicalSortto sort evaluation order of variables based on dependencies, throws error if cyclic dependency is detectedsimulateto run the simulation based on the time-series specifiedPOST /simulateIdentifiableids to use snake_caseCloses #5
Closes #10
Closes #35