Libgpiod Module Fixes - #147
Merged
Merged
Conversation
Code was calling libgpiod functions without them linked.
gpiod line requests reserve the line. The original code was attempting to reserve a single line twice by setting both direction and interrupt mode. When the direction is in, setting to input is not required since the code will instead set a rising edge, falling edge (or both) type notifications on a single line. See docs here: https://libgpiod-dlang.dpldocs.info/source/gpiod.d.html#L1054
poll_pri ignores GPIO interrupt events since they're not priority. poll_in detects GPIO interrupt events as normal input. This resolves the issue with libgpiod module not picking up rfid card swipes. Setting to poll_in fixes this.
Member
|
Indeed this is much better. Thanks for the PR @joshusooyaa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libgpiod was not working due to linking errors, requesting the same gpio line multiple times (after being reserved) and using the incorrect interrupt type. This PR attempts to fix these by linking the libgpiod package, requesting only one GPIO line based off of the direction and interrupt mode, and updates the interrupt type to poll_in as opposed to poll_pri.