Use reflex - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the application from a Qt-based desktop application to a web application using Reflex. The migration includes replacing the PySide6 UI framework with a web-based interface while maintaining the core working time verification functionality. Additionally, it updates the package structure to use the newer factorialhr API client.
Key changes:
- Migrated from Qt/PySide6 desktop application to Reflex web framework
- Replaced synchronous API calls with async patterns using httpx and anyio
- Updated authentication from API key-only to OAuth2 with refresh token support
Reviewed Changes
Copilot reviewed 28 out of 35 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_working_time_verification.py | New comprehensive test suite for working time verification module |
| tests/test_verifier.py | Removed old verifier test file |
| src/fwtv/ | Removed entire Qt-based desktop application source directory |
| rxconfig.py | Added Reflex configuration file |
| pyproject.toml | Updated dependencies and project structure for web application |
| factorialhr_analysis/ | Added new web application source with pages, components, and verification logic |
| README.md | Updated usage instructions for web application deployment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.