Move Parquet saving into a separate item list collector#1127
Open
mdekstrand wants to merge 6 commits into
Open
Move Parquet saving into a separate item list collector#1127mdekstrand wants to merge 6 commits into
mdekstrand wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1127 +/- ##
===========================================
- Coverage 89.53% 17.83% -71.71%
===========================================
Files 256 209 -47
Lines 17167 14419 -2748
===========================================
- Hits 15370 2571 -12799
- Misses 1797 11848 +10051 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
ParquetItemListCollectorthat saves item lists as we go to a Parquet file, and does some smaller type improvements and refactors to the data code.