Skip to content

Add nested thread pool support and use it in hyperparameter tuning#1125

Merged
mdekstrand merged 6 commits into
lenskit:mainfrom
mdekstrand:feature/1124-tuning-pools
Jun 30, 2026
Merged

Add nested thread pool support and use it in hyperparameter tuning#1125
mdekstrand merged 6 commits into
lenskit:mainfrom
mdekstrand:feature/1124-tuning-pools

Conversation

@mdekstrand

Copy link
Copy Markdown
Member

This adds the plumbing support for multiple accelerator pools, runs accelerator tasks in separate pools when enabled, and uses nested pools in the multi-threaded Optuna tuner.

Closes #1124.

@mdekstrand mdekstrand added this to the 2026.3 milestone Jun 30, 2026
@mdekstrand mdekstrand self-assigned this Jun 30, 2026
@mdekstrand mdekstrand added internals Internal infrastructure (parallelism, math, etc.) performance tuning labels Jun 30, 2026
@mdekstrand mdekstrand moved this from Backlog to In Progress in LensKit Development Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.53%. Comparing base (9e2604d) to head (2e97bc2).

Files with missing lines Patch % Lines
src/accel/tasks/mod.rs 55.00% 9 Missing ⚠️
src/accel/parallel.rs 78.94% 4 Missing ⚠️
src/lenskit/parallel/_pool.py 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   89.56%   89.53%   -0.04%     
==========================================
  Files         255      256       +1     
  Lines       17090    17167      +77     
==========================================
+ Hits        15307    15370      +63     
- Misses       1783     1797      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdekstrand mdekstrand merged commit 0f8d1f6 into lenskit:main Jun 30, 2026
39 of 41 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LensKit Development Jun 30, 2026
@mdekstrand mdekstrand deleted the feature/1124-tuning-pools branch June 30, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internals Internal infrastructure (parallelism, math, etc.) performance tuning

Projects

Development

Successfully merging this pull request may close these issues.

Use separate thread pools in parallel tuning jobs

1 participant