Do not emit avatar on presence errors#511
Merged
Merged
Conversation
Contributor
Author
|
build fails, but I think this is not relates to this PR and some other problem |
Owner
|
Thanks! I'll take care of any build issues |
Owner
|
Published as 12.21.1, with some updated dependencies to catch up on JS tooling changes. |
Contributor
Author
|
thanks again for your super fast merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
avatar events are emitted also for error presences that contain vcard avatar info. Those error presences are often just remote timeouts. Or stale contacts where the server does not exist anymore.
In those cases I get back my own presence that raises an avatar event with my own avatar hash, but the bare Jid of a contact. This can force clients to apply your own avatar to contacts.
I think error presences should not emit the avatar. Or is there a better way to handle this?
Fix
Just ignore error presences in the vcard avatar code