Refactor handling of AnimatedObjects#794
Closed
leezer3 wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Hmm... Structural issues are a major problem here :/ This might want a rethink / major rework of the entire CarSection approach... |
Owner
Author
|
https://github.com/leezer3/OpenBVE/tree/CarSectionRefactor Marginally tested rework of the CarSection, to be used as an alternative to this. Appears to work 'better' but I'm not at all convinced with the entire ObjectState concept :/ I think this one should actually allow the HierarchyAnimatedObjects to be used in a CarSection, but may well break in new and interesting ways..... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors AnimatedObjects so that they are a subset of the overarching UnifiedObject
Required by #684 in order to get the HierarchyAnimatedObjects working correctly, as these require a totally different update method.
TODO: