fix(concat): two critical ffmpeg filter_complex bugs - #8
Merged
Conversation
Bug 1: Empty filter name when fade_in=fade_out=0 Generated: [0:v]setpts=PTS-STARTPTS,[v0] ffmpeg parsed ',' as filter separator → [v0] treated as filter name Fix: [0:v]setpts=PTS-STARTPTS[v0] (no comma between filter and output pad) Bug 2: Audio stream lost in _normalize_video -an deleted original audio, but need_audio logic skipped recovery when source had audio (has_audio=True → need_audio=False). Result: normalized videos had no audio → acrossfade 'matches no streams'. Fix: replace -an with -c:a copy to preserve original audio stream. Both bugs caused filter_complex path to fail with exit code 8. Fast path was unaffected. Closes: concat-engine-ffmpeg-bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix empty filter name (comma bug) and audio stream loss (-an bug) in concat_engine filter_complex path.