fix(cta): prevent multiple CTA segments — only last segment gets cta - #6
Merged
Conversation
Problem:
segments.json had 5 segments marked as 'cta' (s07, s09, s35, s42, s44).
CTA should only appear at the video end.
Fixes:
- core/segment_tts.py: add guard in SemanticTypeAnalyzer.analyze()
→ non-last segments inferred as 'cta' are downgraded to 'narrative'
- extensions/storyboard/storyboard_ai.py: same guard in _infer_segment_type()
- rules/segment_types.json:
• raise 'last' position confidence from 0.6 → 0.9
• replace generic CTA keywords ('follow', 'like') with explicit phrases
('关注我们', '点赞支持', '扫码加入'...) to reduce false triggers
- scripts/fix_cta_overuse.py: one-shot repair script for existing segments.json
Also repaired output/rsi_cn/segments.json locally (5 cta -> narrative).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CTA overuse: add guard in segment_tts and storyboard_ai to ensure only the last segment is inferred as 'cta'. Also tighten segment_types.json keywords and provide repair script.