Skip to content

fix: promote uses syncSources with version filter, add final wait#127

Merged
rtibbles merged 1 commit into
mainfrom
fix/promote-and-final-wait
Apr 2, 2026
Merged

fix: promote uses syncSources with version filter, add final wait#127
rtibbles merged 1 commit into
mainfrom
fix/promote-and-final-wait

Conversation

@rtibbles

@rtibbles rtibbles commented Apr 2, 2026

Copy link
Copy Markdown
Member

Summary

  • promote: Replace copyPackage (not available on Launchpad 1.0 API) with syncSources, grouped by series with per-series error handling
  • promote --version: Required parameter filters to only promote the specified version, preventing old packages (e.g. cosmic) from causing failures
  • workflow: Add wait-for-published step after promote to confirm packages are published in the release PPA before the workflow completes

References

  • Fixes AttributeError: object has no attribute 'copyPackage' in promote step
  • Fixes cosmic series failure caused by old unrelated packages in proposed PPA

Reviewer guidance

  • promote() now takes a required version parameter and uses syncSources (same as copy_to_series)
  • Workflow passes --version from check_version outputs
  • Final wait-for-published --ppa kolibri confirms the release PPA has published binaries
  • All tested live: promote succeeded for 7 series, no cosmic error

AI usage

Claude Code implemented and tested live against Launchpad. 42 unit tests pass.

- promote: replace copyPackage (not available on 1.0 API) with
  syncSources, grouped by series. Per-series error handling matches
  copy_to_series pattern.
- workflow: add wait-for-published step after promote to confirm
  packages are published in the release PPA before completing.
- workflow: copy_package_from_proposed_to_ppa now depends on
  check_version for the version output.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rtibbles rtibbles merged commit f9b2107 into main Apr 2, 2026
15 of 25 checks passed
@rtibbles rtibbles deleted the fix/promote-and-final-wait branch April 2, 2026 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant