Skip to content

fix: has_published_binaries logic and no-binaries copy error #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rtibbles wants to merge 1 commit into from
Closed

fix: has_published_binaries logic and no-binaries copy error #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/launchpad_copy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def get_builds_for(self, ppa, name, version, series_name):

def has_published_binaries(self, ppa, name, version, series_name):
builds = self.get_builds_for(ppa, name, version, series_name)
return not builds or builds[0].buildstate == "Successfully built"
return bool(builds) and builds[0].buildstate == "Successfully built"

def get_usable_sources(self, ppa, package_names, series_name):
res = []
Expand Down Expand Up @@ -253,8 +253,11 @@ def perform_queued_copies(self, ppa):
source_names=sorted(names),
)
except lre.BadRequest as e:
if "same version already published" in str(e):
msg = str(e)
if "same version already published" in msg:
log.info("Already copied to %s — skipping", target_series)
elif "has no binaries to be copied" in msg:
log.warning("Binaries not yet published — skipping copy to %s", target_series)
else:
raise

Expand Down
Loading