Skip to content

fix: remove functools.cache from methods receiving Launchpad Entry objects #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtibbles merged 2 commits into from
Apr 1, 2026
Merged

fix: remove functools.cache from methods receiving Launchpad Entry objects #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60281a9
fix: remove functools.cache from methods receiving Launchpad Entry ob…
rtibbles Apr 1, 2026
2671678
fix: update tests to call get_usable_sources directly
rtibbles Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions scripts/launchpad_copy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ def get_series(self, name):
log.debug("Locating the series: %s...", name)
return ppa.distribution.getSeries(name_or_version=name)

@functools.cache
def get_published_sources(self, ppa, series_name=None, status=None):
kwargs = {}
if series_name:
Expand All @@ -169,7 +168,6 @@ def get_published_sources(self, ppa, series_name=None, status=None):
log.debug("Listing source packages...")
return ppa.getPublishedSources(**kwargs)

@functools.cache
def get_builds_for_source(self, source):
log.debug(
"Listing %s builds for %s %s...",
Expand All @@ -179,7 +177,6 @@ def get_builds_for_source(self, source):
)
return source.getBuilds()

@functools.cache
def get_source_packages(self, ppa, series_name, package_names=None):
"""Return {package_name: {version: source, ...}, ...}"""
res = defaultdict(dict)
Expand Down Expand Up @@ -207,7 +204,6 @@ def has_published_binaries(self, ppa, name, version, series_name):
builds = self.get_builds_for(ppa, name, version, series_name)
return not builds or builds[0].buildstate == "Successfully built"

@functools.cache
def get_usable_sources(self, ppa, package_names, series_name):
res = []
for source in self.get_published_sources(ppa, series_name):
Expand Down
4 changes: 2 additions & 2 deletions tests/test_launchpad_copy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def test_get_usable_sources_filters_by_whitelist(self):
src_bad.status = "Published"

with patch.object(wrapper, "get_published_sources", return_value=[src_good, src_bad]):
result = LaunchpadWrapper.get_usable_sources.__wrapped__(wrapper, mock_ppa, ("kolibri-server",), "jammy")
result = wrapper.get_usable_sources(mock_ppa, ("kolibri-server",), "jammy")

assert len(result) == 1
assert result[0] == ("kolibri-server", "1.0")
Expand All @@ -255,7 +255,7 @@ def test_get_usable_sources_skips_superseded(self):
src.status = "Superseded"

with patch.object(wrapper, "get_published_sources", return_value=[src]):
result = LaunchpadWrapper.get_usable_sources.__wrapped__(wrapper, mock_ppa, ("kolibri-server",), "jammy")
result = wrapper.get_usable_sources(mock_ppa, ("kolibri-server",), "jammy")

assert len(result) == 0

Expand Down
Loading