Skip to content

[Domain] Propagate stalled state through queues#277

Open
muzygosu wants to merge 1 commit into
mainfrom
codex/propagate-stalled-queue-state
Open

[Domain] Propagate stalled state through queues#277
muzygosu wants to merge 1 commit into
mainfrom
codex/propagate-stalled-queue-state

Conversation

@muzygosu
Copy link
Copy Markdown
Collaborator

@muzygosu muzygosu commented Jun 4, 2026

Summary

  • 기존 stalled판정에서 이상하다고 느낀점은 앞뒤의 유닛이 stalled일때 그 사이 유닛이 stalled 상태가 아닐때가 있습니다.
    즉, 가운데 유닛이 이동할공간이 조금있다는 의미이고, 뒤에있는 유닛의 stalled가 곧 풀린다는 의미입니다.

앞,뒤 유닛이 stalled상태일때 그 사이 유닛이 stalled여야 자연스럽다는 의미입니다.
그래서 stalled판정에 앞뒤 유닛이 stalled일때 그 사이의 유닛도 stalled가 되도록 변경하였습니다.

  • Propagate the displayed stalled state to a moving agent when it is between stalled neighbors on the same floor and lane.
  • Apply the same post-processing to live simulation frames and T90/T95 keyframes so replay/result visuals stay consistent.
  • Add regression coverage for queue propagation and for avoiding false propagation from a side lane.

Area

  • Engine
  • Domain
  • Application
  • Docs
  • Build
  • Analysis
  • Chore

Architecture Check

  • I kept the dependency direction application -> domain -> engine.
  • I did not add Qt UI code to src/domain.
  • I did not add domain or application dependencies to src/engine.
  • I used src/ as the include root.

Verification

  • cmake --preset windows-debug-no-app
  • cmake --build --preset build-no-app-debug --target safecrowd_tests
  • ctest --preset test-no-app-debug --output-on-failure
  • cmake --build --preset build-debug --target safecrowd_app
  • git diff --check
  • cmake --preset windows-debug
  • cmake --build --preset build-debug
  • ctest --preset test-debug
  • Not run (reason below)

Risks / Follow-up

  • This changes the displayed/result-frame stalled state only; it does not alter movement, pressure, density, bottleneck, or cross-flow physics.
  • The existing MSVC C4819 encoding warning in src/engine/ComponentRegistry.h still appears during builds and is unrelated to this change.

@muzygosu muzygosu marked this pull request as ready for review June 4, 2026 15:19
@muzygosu muzygosu requested a review from learncold as a code owner June 4, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant