[Domain] model hazard detection delay before reaction#273
Open
SilverSupplier wants to merge 2 commits into
Open
[Domain] model hazard detection delay before reaction#273SilverSupplier wants to merge 2 commits into
SilverSupplier wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent::detectionDelaySeconds, and then becomes aware afterreactionDelaySeconds.hazardSensedSinceSeconds); with a zero detection delay the behavior is identical to before, so existing hazard tests are unaffected.detectionDelaySecondsper agent at spawn with a deterministic, seed-derived value (independentbeta22draw, so existing random draws are unchanged).ScenarioEnvironmentHazardSystem_DelaysDetectionUntilDetectionDelayElapsescovering sensed-but-not-detected and detected-then-aware.Area
Architecture Check
application -> domain -> engine.src/domain.domainorapplicationdependencies tosrc/engine.src/as the include root.Verification
cmake --preset windows-debugcmake --build --preset build-debugctest --preset test-debugRan the release / no-app equivalents:
cmake --build --preset build-no-app-release,ctest --preset test-no-app-release-> 100% pass (includes the new detection-delay test). Full Qt app build (cmake --build --preset build-release --target safecrowd_app) also succeeds.Risks / Follow-up
reactionDelaySecondsremains unpopulated at spawn (a pre-existing condition); onlydetectionDelaySecondsis now seeded.