Skip to content

[Application] add run-screen execution controls#272

Open
SilverSupplier wants to merge 4 commits into
mainfrom
application/run-screen-execution-controls
Open

[Application] add run-screen execution controls#272
SilverSupplier wants to merge 4 commits into
mainfrom
application/run-screen-execution-controls

Conversation

@SilverSupplier
Copy link
Copy Markdown
Collaborator

@SilverSupplier SilverSupplier commented Jun 2, 2026

Summary

  • Add a "Run settings" group to the simulation run screen (ScenarioRunWidget) with Time limit, Sample interval, Repeats, and Seed controls plus an "Apply selected & restart" action, so run parameters can be set from the run screen as described in the project report (section 5.3).
  • Apply writes the values into the selected scenario's execution config (not the whole batch), resets the batch runner, rebuilds the run canvas/cards, and re-selects the edited scenario's run. The change is also synced back to the return-to-authoring state.
  • Apply asks for confirmation before discarding completed/cached simulation results, so a finished run is not lost by accident.
  • Controls initialize from the selected scenario's execution config and update when the selected run changes.

Area

  • Engine
  • Domain
  • Application

Architecture Check

  • I kept the dependency direction application -> domain -> engine.
  • I did not add Qt UI code to src/domain.
  • I did not add domain or application dependencies to src/engine.
  • I used src/ as the include root.

Verification

  • cmake --preset windows-debug
  • cmake --build --preset build-debug
  • ctest --preset test-debug
  • Not run (reason below)

Built the Qt app in release: cmake --build --preset build-release --target safecrowd_app -> succeeds. UI-only change driven through the existing domain execution config and batch runner reset.

Risks / Follow-up

  • Settings apply per selected scenario; "Apply selected & restart" restarts the batch and clears cached results after confirmation when a completed run would be discarded.

@SilverSupplier SilverSupplier requested a review from learncold as a code owner June 2, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant