Patch --> Workaround for leancodepl/patrol#2843: Dart side reported failure with no details — #3076
Open
prakhar-grexa wants to merge 3 commits into
Open
Patch --> Workaround for leancodepl/patrol#2843: Dart side reported failure with no details — #3076prakhar-grexa wants to merge 3 commits into
prakhar-grexa wants to merge 3 commits into
Conversation
…reating failures with no details as passes. Update error handling in PatrolJUnitRunner.
prakhar-grexa
requested review from
fylyppo,
mateuszwojtczak,
pdenert and
piotruela
as code owners
github-actions
Bot
added
the
package: patrol
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a workaround for issue #2843 in PatrolJUnitRunner.java. It modifies the runDartTest method to treat Dart test failures without details as successes, logging a warning instead of throwing an AssertionError. This addresses phantom teardown failures where all test steps passed. I have no feedback to provide.
added 2 commits
May 18, 2026 15:32
…ccess for failures with null details. Update error handling in PatrolAppService.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
known to fire as a phantom teardown even when every test step passed. Treat as success.