Skip to content

Make ImportCommand service lazy to prevent database connection on Symfony cache clear#52

Merged
thislg merged 4 commits into
masterfrom
service-lazy
Dec 11, 2025
Merged

Make ImportCommand service lazy to prevent database connection on Symfony cache clear#52
thislg merged 4 commits into
masterfrom
service-lazy

Conversation

@pierreboissinot

Copy link
Copy Markdown
Member

No description provided.

@lucasmirloup

lucasmirloup commented Dec 11, 2025

Copy link
Copy Markdown
Member

Merci Pierre 👍

Pour info, en Symfony 8+, si je ne dis pas de bêtises, les commandes migrées en __invoke() (faisable à l'aide de Rector) deviennent lazy par défaut.

@pierreboissinot

pierreboissinot commented Dec 11, 2025

Copy link
Copy Markdown
Member Author

Merci Pierre 👍

Pour info, en Symfony 8+, si je ne dis pas de bêtises, les commandes migrées en __invoke() (faisable à l'aide de Rector) deviennent lazy par défaut.

Sûrement, il y a aussi l'attribute AsCommand qui remplace la prop static defaultName mais je ne voulais pas faire de bc break par rapport au support de PHP 7

@lucasmirloup lucasmirloup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thislg

thislg commented Dec 11, 2025

Copy link
Copy Markdown
Member

On supporte Symfony 5.4 et plus.

@thislg thislg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK à part une question.

Comment thread Resources/config/services.php
@thislg thislg self-requested a review December 11, 2025 16:07
@thislg thislg merged commit 5c89f70 into master Dec 11, 2025
7 checks passed
@thislg thislg deleted the service-lazy branch December 11, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants