improve performance of schema and position lookups during feature decoding#560
Open
cportele wants to merge 1 commit into
Open
improve performance of schema and position lookups during feature decoding#560cportele wants to merge 1 commit into
cportele wants to merge 1 commit into
Conversation
…oding The decoding context exposes schema(), pos(), parentPos() and parentSchemas() as @Value.Lazy, but @Value.Lazy is not cached on a @Value.Modifiable, so each call re-resolved the per-path lookups - a map lookup keyed by the path list - on the schema mapping. Memoize the lookups on the context, keyed by a version counter on the path tracker that changes whenever the tracked path changes: - FeaturePathTracker gains a version counter and isEmpty(); - the four accessors delegate to overridable per-path lookups that the modifiable context resolves once per path and reuses. The real mapping getters are still called, so dynamic schema transformers remain in effect; output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decoding context exposes schema(), pos(), parentPos() and parentSchemas() as @Value.Lazy, but @Value.Lazy is not cached on a @Value.Modifiable, so each call re-resolved the per-path lookups - a map lookup keyed by the path list - on the schema mapping.
Memoize the lookups on the context, keyed by a version counter on the path tracker that changes whenever the tracked path changes:
The real mapping getters are still called, so dynamic schema transformers remain in effect; output is unchanged.